Update v1alpha1 RayCluster CRD and controllers #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bump the dependency versions - Golang 1.15 - Kubernetes 1.19.14 - controller-runtime 0.7.2 - controller-tools 0.5.0 Signed-off-by: Jiaxin Shan <seedjeffwan@gmail.com>
- Rename `WorkerGroupsSpec` to `WorkerGroupSpecs` - Remove HeadService and add ServiceType and EnableIngressin headGroupSpec - Add EnableInTreeAutoscaling field - Add rich information in RayClusterStatus Signed-off-by: Jiaxin Shan <seedjeffwan@gmail.com>
1. Refactor some internal methods to make invoking chains clear 2. Clean up some stale codes Signed-off-by: Jiaxin Shan <seedjeffwan@gmail.com>
Signed-off-by: Jiaxin Shan <seedjeffwan@gmail.com>
|
I am running and adding more tests to make sure it has good coverage. |
akanso
reviewed
Sep 11, 2021
Jeffwan
force-pushed
the
api_changes
branch
from
8ed8290
to
b3665af
Compare
|
This PR doesn't include ingress & in-tree autoscaler support in controllers. A separate PR will be cut later. After this change, future PRs will be small and manageable. |
akanso
approved these changes
Sep 11, 2021
chenk008
approved these changes
Sep 14, 2021
lowang-bh
pushed a commit
to lowang-bh/kuberay
that referenced
this pull request
Sep 24, 2023
* Bump k8s version to 1.19.x and golang to 1.15 Bump the dependency versions - Golang 1.15 - Kubernetes 1.19.14 - controller-runtime 0.7.2 - controller-tools 0.5.0 Signed-off-by: Jiaxin Shan <seedjeffwan@gmail.com> * Update v1alpha1 RayCluster CRD - Rename `WorkerGroupsSpec` to `WorkerGroupSpecs` - Remove HeadService and add ServiceType and EnableIngressin headGroupSpec - Add EnableInTreeAutoscaling field - Add rich information in RayClusterStatus Signed-off-by: Jiaxin Shan <seedjeffwan@gmail.com> * Update raycluster controller 1. Refactor some internal methods to make invoking chains clear 2. Clean up some stale codes Signed-off-by: Jiaxin Shan <seedjeffwan@gmail.com> * Update deploy manifests and examples Signed-off-by: Jiaxin Shan <seedjeffwan@gmail.com> * Address review comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address #13 #17 #21
/cc @akanso @chenk008 @chaomengyuan